Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] L-01 Check parent shnarf exists for calldata submission #223

Merged
merged 4 commits into from
Oct 31, 2024
Merged

Conversation

thedarkjester
Copy link
Collaborator

This PR implements issue(s) #

Checklist

  • I wrote new tests for my new core changes.
  • I have successfully ran tests, style checker and build against my new changes locally.
  • I have informed the team of any breaking changes if there are any.

@thedarkjester thedarkjester requested a review from a team as a code owner October 22, 2024 11:11
@codecov-commenter
Copy link

codecov-commenter commented Oct 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.13%. Comparing base (5dc02f8) to head (53498bd).

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #223      +/-   ##
============================================
+ Coverage     71.04%   71.13%   +0.08%     
+ Complexity     1082     1049      -33     
============================================
  Files           301      290      -11     
  Lines         12319    11733     -586     
  Branches       1154     1042     -112     
============================================
- Hits           8752     8346     -406     
+ Misses         3075     2917     -158     
+ Partials        492      470      -22     
Flag Coverage Δ *Carryforward flag
hardhat 98.68% <100.00%> (+<0.01%) ⬆️
kotlin 68.81% <ø> (-0.03%) ⬇️ Carriedforward from 2104749

*This pull request uses carry forward flags. Click here to find out more.

Files with missing lines Coverage Δ
contracts/contracts/LineaRollup.sol 98.60% <100.00%> (+0.01%) ⬆️

... and 65 files with indirect coverage changes

@thedarkjester thedarkjester changed the title Check parent shnarf exists for calldata submission [Fix] L-01 Check parent shnarf exists for calldata submission Oct 22, 2024
@devdacian
Copy link

Fix looks good to me.

@VGau VGau merged commit 31f946e into main Oct 31, 2024
7 of 8 checks passed
@VGau VGau deleted the fix/L-01 branch October 31, 2024 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants